Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • B buck
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 201
    • Issues 201
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 22
    • Merge requests 22
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • Meta
  • buck
  • Merge requests
  • !1907

Remove searching for Swift 2.3 toolchain

  • Review changes

  • Download
  • Email patches
  • Plain diff
Closed Administrator requested to merge github/fork/robbertvanginkel/remove_swiftoolchain into master Jun 05, 2018
  • Overview 1
  • Commits 2
  • Pipelines 0
  • Changes 6

Created by: robbertvanginkel

Xcode 8.0 - 8.2.1 supported switching swift versions by having an extra Swift_2_3.toolchain embedded in Xcode, and overriding the search paths for tools like swiftc if the version was changed.

Since then Xcode/Swift's model for supporting different versions of the swift source by passing in a -swift-version flag to the compiler. This was added to buck, so we now pass this flag instead of overriding toolchains. As earlier swift toolchian versions won't understand the flag which is now the buck way of specifying a language, this toolchain search code can now be cleaned up.

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: github/fork/robbertvanginkel/remove_swiftoolchain