Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • B buck
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 201
    • Issues 201
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 22
    • Merge requests 22
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • Meta
  • buck
  • Merge requests
  • !1018

Update manifest merger

  • Review changes

  • Download
  • Email patches
  • Plain diff
Closed Administrator requested to merge github/fork/marcinkwiatkowski/update-manifest-merger into master Nov 16, 2016
  • Overview 54
  • Commits 20
  • Pipelines 0
  • Changes 117

Created by: marcinkwiatkowski

This switches to ManifestMerger2 implementation and fixes https://github.com/facebook/buck/issues/299

Majority of this PR is updating aosp to 25.2.0 version of the tools.

The only interesting change is in GenerateManifestStep.java.

For the sake of not maintaining two versions of aosp, this PR replaces old ManifestMerger with ManifestMerger2. Having both is possible (we could take ManifestMerger from tools 24.x.x, the last version that shipped with it) but if the new merger works for everyone, probably best to just go with that.

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: github/fork/marcinkwiatkowski/update-manifest-merger