Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • C covid19india-react
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 27
    • Issues 27
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 11
    • Merge requests 11
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • covid19india
  • covid19india-react
  • Merge requests
  • !993

Fix: Preload fonts to improve performance

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Administrator requested to merge github/fork/abhishekakade/font-preloading into master Apr 12, 2020
  • Overview 5
  • Commits 1
  • Pipelines 0
  • Changes 26

Created by: abhishekakade

Description of PR

  • This will preload the font files instead of waiting for main JS file to parse and then load fonts.
  • Since font files or their names are not going to change, it is fine if they don't get hashed on each webpack build and so I placed them in public/fonts folder.
  • Moved font-face declarations of these preloaded fonts to index.html to prevent render blocking css (fixed in second commit).
  • This is supposed to improve performance and loading but since I could not test the production build version locally or on my own repo with gh-pages (maps and other things were not loading), I only tested the un-minified dev build which will not provide much insight on actual performance of minified production build. So this should be tested in a separate branch first and then merged with the main branch.

Type of PR

  • Bugfix

Checklist

  • Compiles and passes lint tests
  • Properly formatted
  • Tested on desktop
  • Tested on phone

Screenshots

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: github/fork/abhishekakade/font-preloading