Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • C covid19india-react
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 27
    • Issues 27
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 11
    • Merge requests 11
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • covid19india
  • covid19india-react
  • Merge requests
  • !1246

Refactor: Replace hover events with click on map

  • Review changes

  • Download
  • Email patches
  • Plain diff
Closed Administrator requested to merge github/fork/shuklaayush/fix/remove-map-hover into master Apr 18, 2020
  • Overview 5
  • Commits 3
  • Pipelines 0
  • Changes 3

Created by: shuklaayush

Description of PR The behaviour is now consistent with touch screens. Single click to select, and double click to expand map.

Also removed back button. Double clicking outside map will now go back to country view.

PS: This PR is subject to scrutiny if this behaviour does not seem fit for PC.

Type of PR

  • Bugfix
  • New feature

Relevant Issues
Fixes #717 (closed), fixes #1243 (closed)

Checklist

  • Compiles and passes lint tests
  • Properly formatted
  • Tested on desktop
  • Tested on phone
Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: github/fork/shuklaayush/fix/remove-map-hover