Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • M millennials-to-snake-people
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 4
    • Issues 4
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 2
    • Merge requests 2
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • Byte Blaze
  • millennials-to-snake-people
  • Merge requests
  • !23

Do not replace 'tween

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Administrator requested to merge github/fork/AGSPhoenix/master into master Apr 28, 2017
  • Overview 4
  • Commits 3
  • Pipelines 0
  • Changes 1

Created by: AGSPhoenix

'Tween is incorrectly replaced. Doesn't affect most text on the web, but I recently read a short story with a character from the American South, and it got pretty butchered.

This patch uses a technique I stoleborrowed from this post on SE. It uses a clever regex to capture the ' and change the replacement output depending on whether it was detected.

I used the following as my test suite and it properly handles them all:

tween
tweens
between
tweener
trouble 'tween the two
Those tweens are ruining everything

If you have any questions or comments, fire away.

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: github/fork/AGSPhoenix/master