Skip to content
GitLab

[C++][Pistache] Fix compile break, error handling

Merged Administrator requested to merge github/fork/JulianGmp/pistache_overhaul_bugfixes into master

Created by: JulianGmp

Here I am fixing bugs I myself have created.

Fix a compile break for validation code:

The overload for the models validate(std::stringstream&, const std::string&) was marked as private, which lead to model classes being unable to use the helper when validating other classes. The function was made public, with a summary comment noting that it is not of much use for the user.

Fix error handling in handleParsingException:

The defaultl implementation of handleParsingException handles exceptions based on their type. In order to check the type, the caught exception is rethrown in a try block. However, it is important to rethrow using throw; and not with throw exVariable;. The latter does not preserve derived class information (See https://stackoverflow.com/questions/2360597/c-exceptions-questions-on-rethrow-of-original-exception). This lead to all runtime exceptions being treated like generic exceptions and raised an internal server error (500).

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples: 
    ./mvnw clean package 
./bin/generate-samples.sh
./bin/utils/export_docs_generators.sh
    Commit all changed files. This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master. These must match the expectations made by your contribution. You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*. For Windows users, please run the script in Git BASH.
  • File the PR against the correct branch: master, 5.1.x, 6.0.x
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request. @ravinikam (2017/07) @stkrwork (2017/07) @etherealjoy (2018/02) @MartinDelille (2018/03) @muttleyxd (2019/08)