Created by: FrankEssenberger
This is an attempt to fix the bug reported here: #5467 (closed)
The problem was that the union types in typescrit e.g. TypeA | TypeB represented by the oneOf keyword in the service definition lead to not valid code:
import{TypeA | TypeB} from '../models'you can either use a comma in the import or split into separate imports. I did the latter one because I thought this could be more solid for models in different files and paths potentially. If they are not all exported from the same path.
I adjusted it for three typescript generators:
- axios (this I where I was effected)
- node
- angular
Then I stopped and thought it is a good point to start the discussion before I adjust it for all the other Typescript generators.
Since I am new I would highly appreciate some help regarding the following issues:
-
How to run the code formatter. When I run mvn formatter:formatI get hundreds of code changes. -
How to run the tests. Is mvn testfine? -
Not sure about the locations where I put the tests and so on. Perhaps this kind of test has to go somewhere else.
PR checklist
-
Read the contribution guidelines. If contributing template-only or documentation-only changes which will change sample output, build the project beforehand. -
Run the shell script ./bin/generate-samples.shto update all Petstore samples related to your fix. This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master. These must match the expectations made by your contribution. You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example./bin/generate-samples.sh bin/config/java*. For Windows users, please run the script in Git BASH. -
File the PR against the correct branch: master -
Copy the technical committee to review the pull request if your PR is targeting a particular programming language.