Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • O openapi-generator
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 3,476
    • Issues 3,476
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 402
    • Merge requests 402
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • OpenAPI Tools
  • openapi-generator
  • Merge requests
  • !6033

[Python experimental] Add __setattr__ function to ensure signing_info.host is the same as configuration.host when the user assigns signing info

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Administrator requested to merge github/fork/CiscoM31/python-experimental-signing-info-host into master Apr 23, 2020
  • Overview 0
  • Commits 2
  • Pipelines 0
  • Changes 7

Created by: sebastien-rosset

To initialize the configuration, developers can write the following code:

configuration = Configuration(
   host = "http://example.com",
   configuration.signing_info = openapi.HttpSigningConfiguration(
     signing_scheme = intersight.signing.SCHEME_RSA_SHA256,
     ...
   )
)

Or, for whatever reason, they can first create the config object, then assign the signing info:

configuration = Configuration(
   host = "http://example.com"
)
...
configuration.signing_info = openapi.HttpSigningConfiguration(
   signing_scheme = intersight.signing.SCHEME_RSA_SHA256,
   ...
)

In the first case, the host parameter is automatically passed from the Configuration object to the HttpSigningConfiguration. In the second case, the HttpSigningConfiguration.host was None. This PR fixes the problem for the second case, i.e. the developer should not have to set the parameter twice.

PR checklist

  • Read the contribution guidelines.
  • If contributing template-only or documentation-only changes which will change sample output, build the project before.
  • Run the shell script(s) under ./bin/ (or Windows batch scripts under.\bin\windows) to update Petstore samples related to your fix. This is important, as CI jobs will verify all generator outputs of your HEAD commit, and these must match the expectations made by your contribution. You only need to run ./bin/{LANG}-petstore.sh, ./bin/openapi3/{LANG}-petstore.sh if updating the code or mustache templates for a language ({LANG}) (e.g. php, ruby, python, etc).
  • File the PR against the correct branch: master, 4.3.x, 5.0.x. Default: master.
  • Copy the technical committee to review the pull request if your PR is targeting a particular programming language.
Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: github/fork/CiscoM31/python-experimental-signing-info-host