Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • O openapi-generator
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 3,476
    • Issues 3,476
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 402
    • Merge requests 402
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • OpenAPI Tools
  • openapi-generator
  • Merge requests
  • !5240

[BUG][JAVA][spring-mvc] Generated Code for Map of Maps

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Administrator requested to merge github/fork/emileonhardt/fix-4840 into master Feb 07, 2020
  • Overview 0
  • Commits 1
  • Pipelines 0
  • Changes 1

Created by: emileonhardt

Fix for https://github.com/OpenAPITools/openapi-generator/issues/4840 The Java-Code (spring-mvc) generated from OpenAPI-YAML for a Map of Maps ist not syntactically correct.

This is caused by SpringCodegen.java not handling Maps of Maps return types correctly. Its a simple mistake in applying String.split() to extract the Key-Type of the outer Map.

The following Unit Test shows the problem.

@Test
   public void doDataTypeAssignmentNestedMapReturnType() {
        final SpringCodegen codegen = new SpringCodegen();
        codegen.doDataTypeAssignment("Map<String, Map<String, String>>", new SpringCodegen.DataTypeAssigner() {
            @Override
            public void setReturnType(String returnType) {
               assertEquals(returnType,"Map<String, String>");
            }

            @Override
            public void setReturnContainer(String returnContainer) {
                assertEquals(returnContainer, "Map");
            }
        });
    }

Unfortunately, the visibility of doDataTypeAssignment() and DataTypeAssigner is private, so I can't check in the Test.

PR checklist

  • [x ] Read the contribution guidelines.
  • If contributing template-only or documentation-only changes which will change sample output, build the project before.
  • Run the shell script(s) under ./bin/ (or Windows batch scripts under.\bin\windows) to update Petstore samples related to your fix. This is important, as CI jobs will verify all generator outputs of your HEAD commit, and these must match the expectations made by your contribution. You only need to run ./bin/{LANG}-petstore.sh, ./bin/openapi3/{LANG}-petstore.sh if updating the code or mustache templates for a language ({LANG}) (e.g. php, ruby, python, etc).
  • [x ] File the PR against the correct branch: master, 4.3.x, 5.0.x. Default: master.
  • [x ] Copy the technical committee to review the pull request if your PR is targeting a particular programming language. @bbdouglas @sreeshas @jfiala @lukoyanov @cbornet ( @jeff9finger @karismann @Zomzog @lwlee2608 @bkabrda
Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: github/fork/emileonhardt/fix-4840