Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • O openapi-generator
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 3,476
    • Issues 3,476
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 402
    • Merge requests 402
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • OpenAPI Tools
  • openapi-generator
  • Merge requests
  • !5128

[typescript-angular] Import models from a single model/models.ts

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Administrator requested to merge github/fork/crunchbase/alexey/angular-incorrect-inline-import-path into master Jan 28, 2020
  • Overview 0
  • Commits 5
  • Pipelines 0
  • Changes 54

Created by: amakhrov

Fixes https://github.com/OpenAPITools/openapi-generator/issues/5127

The underlying problem causing https://github.com/OpenAPITools/openapi-generator/issues/5127 is that import paths used in api files are produced based on model class names (e.g InlineObject1), while the actual model files written by the generator take filenames based on raw model name (inline_object_1).

Perhaps a proper way would be to eliminate this inconsistency by using the same logic in both places. However, import paths for api are assigned in DefaultGenerator, so the change can potentially have large impact on all generators.

So instead of fixing this inconsistency, this PR offers an alternative solution: ignore individual import paths prepared for api, and import all models from ../model/models.ts. This approach is actually in line with a couple of other typescript generators: typescript-axios, typescript-fetch, typescript-jquery.

PR checklist

  • Read the contribution guidelines.
  • If contributing template-only or documentation-only changes which will change sample output, build the project before.
  • Run the shell script(s) under ./bin/ (or Windows batch scripts under.\bin\windows) to update Petstore samples related to your fix. This is important, as CI jobs will verify all generator outputs of your HEAD commit, and these must match the expectations made by your contribution. You only need to run ./bin/{LANG}-petstore.sh, ./bin/openapi3/{LANG}-petstore.sh if updating the code or mustache templates for a language ({LANG}) (e.g. php, ruby, python, etc).
  • File the PR against the correct branch: master, 4.3.x, 5.0.x. Default: master.
  • Copy the technical committee to review the pull request if your PR is targeting a particular programming language.

@TiFu @taxpon @sebastianhaas @kenisteward @Vrolijkx @macjohnny @nicokoenig @topce @akehir @petejohansonxo

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: github/fork/crunchbase/alexey/angular-incorrect-inline-import-path