Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • O openapi-generator
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 3,476
    • Issues 3,476
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 402
    • Merge requests 402
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • OpenAPI Tools
  • openapi-generator
  • Merge requests
  • !4401

[dart-dio] correctly handle Map<String, Object>, List<Object> using JsonObject

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Administrator requested to merge github/fork/amondnet/dart-dio into master Nov 07, 2019
  • Overview 0
  • Commits 2
  • Pipelines 0
  • Changes 2

Created by: amondnet

https://github.com/google/built_value.dart/issues/134

dart-dio generator does not handle Map<String, dynamic> properly. This PR fixes this issue using JsonObject.

  • Map<String, Object> should be BuiltMap<String,JsonObject>
  • List<Object> should be BuiltList<JsonObject>
  Test:
    properties:
      objectMap:
        type: object
        additionalProperties:
          type: object
      objectList:
        type: array
        items:
          type: object
  @nullable
  @BuiltValueField(wireName: 'objectMap')
  BuiltMap<String, JsonObject> get objectMap;

  @nullable
  @BuiltValueField(wireName: 'objectList')
  BuiltList<JsonObject> get objectList;

PR checklist

  • Read the contribution guidelines.
  • If contributing template-only or documentation-only changes which will change sample output, build the project before.
  • Run the shell script(s) under ./bin/ (or Windows batch scripts under.\bin\windows) to update Petstore samples related to your fix. This is important, as CI jobs will verify all generator outputs of your HEAD commit, and these must match the expectations made by your contribution. You only need to run ./bin/{LANG}-petstore.sh, ./bin/openapi3/{LANG}-petstore.sh if updating the code or mustache templates for a language ({LANG}) (e.g. php, ruby, python, etc).
  • File the PR against the correct branch: master, 4.3.x, 5.0.x. Default: master.
  • Copy the technical committee to review the pull request if your PR is targeting a particular programming language.

CC: @ircecho @swipesight @jaumard @nickmeinhold @athornz

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: github/fork/amondnet/dart-dio