Skip to content
GitLab

Gradle - make GenerateTask properties optional

Merged Administrator requested to merge github/fork/kahowell/gradle_generate_task_fix into master

Created by: kahowell

PR checklist

  • Read the contribution guidelines.
  • Ran the shell script under ./bin/ to update Petstore sample so that CIs can verify the change. (For instance, only need to run ./bin/{LANG}-petstore.sh, ./bin/openapi3/{LANG}-petstore.sh, ./bin/security/{LANG}-petstore.sh and ./bin/openapi3/security/{LANG}-petstore.sh if updating the {LANG} (e.g. php, ruby, python, etc) code generator or {LANG} client's mustache templates). Windows batch files can be found in .\bin\windows\.
  • Filed the PR against the correct branch: master, 3.4.x, 4.0.x. Default: master.
  • Copied the technical committee to review the pull request if your PR is targeting a particular programming language.

Description of the PR

This allows easier creation of custom GenerateTask. Specifically, this makes:

  • generateModelTests
  • generateModelDocumentation
  • generateApiTests
  • generateApiDocumentation
  • withXml

optional, following the same pattern as other properties in GenerateTask.

Without this change, we get java.lang.IllegalStateException: No value has been specified for this provider. until these properties are specified for the task, when attempting to define a custom generate task (such as one to generate API docs).

Note I left a couple of items in PR checklist unmarked as they don't seem relevant to this change. Please let me know if this should be handled differently.