Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • O openapi-generator
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 3,476
    • Issues 3,476
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 402
    • Merge requests 402
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • OpenAPI Tools
  • openapi-generator
  • Merge requests
  • !1718

[swift4] Use RequestBuilder directly for RxSwift and PromiseKit

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Administrator requested to merge swift-reduce-defaults-code into master Dec 20, 2018
  • Overview 0
  • Commits 2
  • Pipelines 0
  • Changes 52

Created by: d-date

PR checklist

  • Read the contribution guidelines.
  • Ran the shell script under ./bin/ to update Petstore sample so that CIs can verify the change. (For instance, only need to run ./bin/{LANG}-petstore.sh and ./bin/security/{LANG}-petstore.sh if updating the {LANG} (e.g. php, ruby, python, etc) code generator or {LANG} client's mustache templates). Windows batch files can be found in .\bin\windows\.
  • Filed the PR against the correct branch: master, 3.4.x, 4.0.x. Default: master.
  • Copied the technical committee to review the pull request if your PR is targeting a particular programming language.

Description of the PR

When we specify RxSwift or PromiseKit to ResponseAs in additional_properties, the generator will generate 3 methods, requestBuilder, default implementation and wrapped method.

We need only requestBuild and wrapped method so that reduce generated codes. This is not breaking change for users.

Before:

open class func addPet(pet: Pet) -> Observable<Void> {
        return Observable.create { observer -> Disposable in
            addPet(pet: pet) { data, error in
                if let error = error {
                    observer.on(.error(error))
                } else {
                    observer.on(.next(data!))
                }
                observer.on(.completed)
            }
            return Disposables.create()
        }
    }

After:

open class func addPet(pet: Pet) -> Observable<Void> {
        return Observable.create { observer -> Disposable in
            addPetWithRequestBuilder(pet: pet).execute { (response, error) -> Void in
                if let error = error {
                    observer.onError(error)
                } else {
                    observer.onNext(())
                }
                observer.onCompleted()
            }
            return Disposables.create()
        }
    }
Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: swift-reduce-defaults-code