Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • O openapi-generator
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 3,476
    • Issues 3,476
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 402
    • Merge requests 402
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • OpenAPI Tools
  • openapi-generator
  • Merge requests
  • !11529

[python-experimental] fn + method signature improvements

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Administrator requested to merge github/fork/spacether/feat_python_exp_caches_schema_validate into master Feb 05, 2022
  • Overview 0
  • Commits 2
  • Pipelines 0
  • Changes 178

Created by: spacether

This PR makes improvements that can enable method Schema._validate caching in the future if one wants to implement it. One would need to:

  • have path_to_item use a generator for the last piece of the path_to_item so duplicate items in the array will have the same hash on their path_to_item
  • have Schema._validate return a dict where the key is empty tuple as path_to_item, and then after that result is returned, append the current path fragment onto all keys in path_to_schemas
  • perhaps pass in a _hash_key=type(arg) argument in the validate method because hash(True) == hash(1) in python

Updates in this PR:

  • InstantiationMetadata changed to ValidationMetadata and only used in validation
  • ValidationMetadata changed to inherit from frozendict, making it immutable
  • InstantiationMetadata no longer passed into __new__ and _from_openapi_data, insetad _configuration is passed in
  • *args becomes arg where possible
  • __new__ and _from_openapi_data signatures kept the same (_configuration passed in) though _from_openapi_data could be rewritten to pass in a parameter named configuration because dicts will always be passed into it as arg. But for __new__, dicts may be passed in as keyword arguments.

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package 
    ./bin/generate-samples.sh
    ./bin/utils/export_docs_generators.sh
    Commit all changed files. This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master. These must match the expectations made by your contribution. You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*. For Windows users, please run the script in Git BASH.
  • File the PR against the correct branch: master (5.3.0), 6.0.x
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.
Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: github/fork/spacether/feat_python_exp_caches_schema_validate