Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • O openapi-generator
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 3,476
    • Issues 3,476
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 402
    • Merge requests 402
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • OpenAPI Tools
  • openapi-generator
  • Issues
  • #4582
Closed
Open
Issue created Nov 22, 2019 by Jim Schubert@jimschubertContributor

[BUG] DefaultCodegen#writeOptional should honor options such as skipOverwrite/codegen ignore

Description

Rules for skipping 50-100 files across a handful of generators is not intuitive.

openapi-generator version

all

Steps to reproduce
  • Add any text to samples/openapi3/client/petstore/ruby/spec/spec_helper.rb
  • Commit a WIP commit
  • Run openapi-generator batch --verbose bin/ci/openapi3-ruby-client-petstore.json
  • Notice no diff because the file is silently skipped due to writeOptional
  • Run ./bin/openapi3/ruby-client-petstore.sh
  • Notice diff because file is deleted in the bash script via:
find samples/openapi3/client/petstore/ruby/spec -type d -not -name spec -not -name custom | xargs rm -Rf
find samples/openapi3/client/petstore/ruby/spec -type f -not -name petstore_helper.rb -not -iwholename '*/spec/custom/*' | xargs rm -Rf
Suggest a fix

Remove support for writeOptional in favor of newer methods for controlling writes. If outputs under samples require these to be unmodified, they should be added to respective .openapi-generator-ignore files.

Assignee
Assign to
Time tracking