Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • D dynamorio
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 1,467
    • Issues 1,467
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 44
    • Merge requests 44
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • DynamoRIO
  • dynamorio
  • Merge requests
  • !5778

i#5675 record filter: Preserve encodings for filtered instrs

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Abhinav Anil Sharma requested to merge i5675-preserve-encodings into master Dec 07, 2022
  • Overview 10
  • Commits 4
  • Pipelines 0
  • Changes 3

Adds logic to preserve encoding entries for instrs that were filtered out. Such preserved encoding entries are delayed to the next instr in the trace for their corresponding pc, if any. This is required because TRACE_TYPE_ENCODING entries must be immediately followed by an instr entry, since they must be tied with a pc.

Extends the record_filter_unit_tests to verify encoding preservation.

We also want to add a unit test that filters a freshly generated trace. But the default generated trace format is .zip now and we don't have zip file reading or writing support in record_filter yet. Added a TODO for now and manually verified the tool on a new .gz trace.

Issue: #5675

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: i5675-preserve-encodings