Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • D dynamorio
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 1,467
    • Issues 1,467
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 44
    • Merge requests 44
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • DynamoRIO
  • dynamorio
  • Merge requests
  • !5748

Ignore bb with null instruction count

  • Review changes

  • Download
  • Email patches
  • Plain diff
Open Kirill requested to merge null_instr_count into master Nov 21, 2022
  • Overview 9
  • Commits 2
  • Pipelines 0
  • Changes 1

In general I have bb with one jmp instruction on java workload

TAG  0x0000000000000000
 +0    m4 @0x00007f9f6ecbbc50  65 48 89 0c 25 d8 00 mov    %rcx -> %gs:0x000000d8[8byte]
                               00 00
 +9    m4 @0x00007f9f6ecba030  65 48 8b 0c 25 38 01 mov    %gs:0x00000138[8byte] -> %rcx
                               00 00
 +18   L3 @0x00007f9f6ecbc868  eb fe                jmp    $0x00007f9f65087e50
END 0x0000000000000000

In this case instru_t::count_app_instrs return the null counts of instructions in list

So, we have assert in converter phase append_bb_entries

...
        if (instr_count == 0) {
            // L0 filtering adds a PC entry with a count of 0 prior to each memref.
            skip_icache = true;
            instr_count = 1;
            // We should have set a flag to avoid peeking forward on instr entries
            // based on OFFLINE_FILE_TYPE_FILTERED and
            // OFFLINE_FILE_TYPE_IFILTERED.
            DR_ASSERT(instrs_are_separate);
...

Could I just ignore such bb? Thx, Kirill

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: null_instr_count