Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • D dynamorio
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 1,467
    • Issues 1,467
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 44
    • Merge requests 44
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • DynamoRIO
  • dynamorio
  • Merge requests
  • !5627

i#5620: Fix drmemtrace marker placement issues

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Derek Bruening requested to merge i5620-marker-placement into master Aug 23, 2022
  • Overview 1
  • Commits 2
  • Pipelines 0
  • Changes 6

Removes appending of non-kernel-xfer markers mid-block in raw2trace: it was added as a mistake it seems. We assume that all our markers are at block boundaries, except kernel transfers which can happen mid-block.

Adds three new invariant checks: that function markers are not between an instruction and memref, that function markers are after branches, and that function return addresses match the prior call instruction's next pc.

Adds tests to raw2trace_unit_tests and to invariant_checker_tests.

Fixes #5620 (closed)

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: i5620-marker-placement