Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • D dynamorio
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 1,467
    • Issues 1,467
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 44
    • Merge requests 44
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • DynamoRIO
  • dynamorio
  • Merge requests
  • !5543

Only enable alt-arch tools/clients when available

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Felix Moessbauer requested to merge syswide-only-enable-installed-clients into master Jun 24, 2022
  • Overview 8
  • Commits 2
  • Pipelines 0
  • Changes 1

This patch adds a check when parsing the tool config files: Clients for alternative archs (e.g. for cross-exec) injection are only appended if the path to the client lib actually exists.

This is a preparation for system-wide deployments, where this check has to be performed at runtime as users might only install the dr library for a single architecture.

Previously having invalid paths in the tool config file worked if the respective client was not requested, but led to a warning. With this patch, the missing client is simply not registered at all.

Issue: #5153

Signed-off-by: Felix Moessbauer [email protected]

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: syswide-only-enable-installed-clients