Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • D dynamorio
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 1,467
    • Issues 1,467
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 44
    • Merge requests 44
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • DynamoRIO
  • dynamorio
  • Merge requests
  • !5506

i#4014 dr$sim phys: Avoid malloc in physaddr_t

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Derek Bruening requested to merge i4014-no-malloc into master May 27, 2022
  • Overview 9
  • Commits 3
  • Pipelines 0
  • Changes 3

Switches from std::unordered_map in physaddr_t to a drcontainers hashtable to avoid malloc and make things safe for statically-linked drmemtrace.

Similarly, switches from std::ostringstream to dr_snprintf in physaddr_t::init() to avoid malloc.

Tested on a multi-threaded app which hits the post-init malloc warning without both fixes (test will be added in a forthcoming PR: it cannot be added now as physaddr_t is not thread-safe yet).

Issue: #4014

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: i4014-no-malloc