Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • D dynamorio
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 1,467
    • Issues 1,467
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 44
    • Merge requests 44
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • DynamoRIO
  • dynamorio
  • Merge requests
  • !5464

i#5463: Avoid globals pre-relocation

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Derek Bruening requested to merge i5463-relocate-dr-crash into master Apr 14, 2022
  • Overview 1
  • Commits 2
  • Pipelines 0
  • Changes 2

Fixes errors that can lead to crashes in relocate_dynamorio, where its access to a function pointer and to the page size can both return garbage pre-relocation. We solve this with assembly to get the current PC, and just using a 4K minimum page size for the backward walk.

Tested with the PR #5462 branch where the new client.attach_blocking test crashes without this fix on AArch64. Manually tested on arm as well.

Fixes #5463 (closed)

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: i5463-relocate-dr-crash