Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • D dynamorio
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 1,467
    • Issues 1,467
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 44
    • Merge requests 44
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • DynamoRIO
  • dynamorio
  • Merge requests
  • !5422

i#5421: Prevent app from closing dual_map_file.

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Abhinav Anil Sharma requested to merge i5421-dual-map-file-oom into master Mar 14, 2022
  • Overview 3
  • Commits 12
  • Pipelines 0
  • Changes 2

Adds the dual_map_file to the DR fd_table. This is to prevent the app from closing this FD, which manifests as an OOM on an extending commit.

Unfortunately, due to constraints on the order of invocation of vmm_heap_unit_init and d_r_os_init in dynamorio_app_init_part_two_finalize, the fd_table is not initialized when the dual_map_file is created. This means that fd_table_add will not really add it to the fd_table. So, we remember the dual_map_file_fd and add it to fd_table when we create it.

Modifies the handling for the global log file to use the same mechanism, instead of adding it explicitly in the DEBUG build.

Also adds a -satisfy_w_xor_x variant for the client.file_io test which attempts to close DR FDs. It fails without adding dual_map_file to fd_table.

Also adds the same variant for the common.loglevel test where both, the global log file and the dual_map_file, are recorded for later fd_table_add.

Fixes: #5421 (closed)

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: i5421-dual-map-file-oom