Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • D dynamorio
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 1,467
    • Issues 1,467
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 44
    • Merge requests 44
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • DynamoRIO
  • dynamorio
  • Merge requests
  • !5380

i#4922: Fix tool.drcachesim.phys on AArch64.

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Abhinav Anil Sharma requested to merge i4922-aarch64-drcachesim-phys into master Feb 18, 2022
  • Overview 1
  • Commits 4
  • Pipelines 0
  • Changes 5

Fixes the incorrect usage of OP_stur in tool.drcachesim.phys test on AArch64. This was caused by delaying instrumentation for too many instructions, so that when we finally did instrument them, we exceeded the maximum immediate displacement allowed by OP_stur. Our code needs to use OP_stur because the trace_entry_t has a size of 12 bytes, meaning that every other entry in the buffer will have a non-8-byte-aligned address for the addr field.

Grants the online_instr_t class the ability to update the trace buffer pointer by passing the required function to it.

Also removes the test from the ignore list for AArch64.

Fixes: #4922 (closed)

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: i4922-aarch64-drcachesim-phys