Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • D dynamorio
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 1,467
    • Issues 1,467
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 44
    • Merge requests 44
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • DynamoRIO
  • dynamorio
  • Merge requests
  • !5374

i#5356 bbdup-drwrap: Add drwrap cleanup-only support

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Derek Bruening requested to merge i5356-drwrap-interrupted into master Feb 18, 2022
  • Overview 36
  • Commits 6
  • Pipelines 0
  • Changes 6

To best handle wrapping functions with drwrap in only some drbbdup instrumentation cases, drwrap now provides a cleanup-only instrumentation feature which is called in drbbdup cases without wrapping. This ensures that key cleanup like restoring replaced return addresses is performed without worrying about sychronously clearing state in all threads on a drbbdup case transition.

To avoid having 2 analysis functions on top of the now 2 insert functions, removes the analysis code completely as it was empty.

Adds a test which mis-behaves without this feature.

Issue: #5356 (closed), #3995

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: i5356-drwrap-interrupted