Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • D dynamorio
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 1,467
    • Issues 1,467
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 44
    • Merge requests 44
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • DynamoRIO
  • dynamorio
  • Merge requests
  • !5252

i#2985 scatter-gather: Fix spill/restore of scratch xmm reg.

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Abhinav Anil Sharma requested to merge i2985-fix-scratch-mm-spill-restore into master Dec 15, 2021
  • Overview 21
  • Commits 8
  • Pipelines 0
  • Changes 4

Fixes spill and restore for the scratch xmm reg. Mov-ing to the lower xmm bits zeroes the upper bits of the corresponding ymm and zmm reg. So we need to spill and restore the entire ymm or zmm reg, whichever is the largest one reg supported by the system, and not just the xmm part of it.

Also adjusts the state restoration machine to expect the new spill instrs.

Replaces the linear address of spill slot in instrumentation with an address computed online using the TLS reg.

Extends the allasm-scattergather test to verify the whole zmm reg after the scatter/gather expansion. On systems without AVX512, we verify ymm. This test fails without the fix.

Issue: #2985 (closed)

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: i2985-fix-scratch-mm-spill-restore