Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • D dynamorio
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 1,467
    • Issues 1,467
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 44
    • Merge requests 44
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • DynamoRIO
  • dynamorio
  • Merge requests
  • !5249

i#5247: Handle exclusive loads sharing store result

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Derek Bruening requested to merge i5247-ldstex-dest-same into master Dec 13, 2021
  • Overview 25
  • Commits 7
  • Pipelines 0
  • Changes 2

Adds handling for AArch64 exclusive loads whose destination equals the result register of the paired exclusive store. For optimized same-block handling, without this fix our value comparison loops forever as it clobbers the original value by using the dead store result register.

The fix is to use a scratch register, but this fails for stolen register cases: thus we bail to the slowpath for those. We also have to re-order the compare to ensure we look at the matching case first, as the compare must write to the same result register.

Adds test cases to the ldstex test. Tested manually on an ARM machine.

Fixes #5247 (closed)

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: i5247-ldstex-dest-same