Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • D dynamorio
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 1,467
    • Issues 1,467
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 44
    • Merge requests 44
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • DynamoRIO
  • dynamorio
  • Merge requests
  • !5237

i#2985 scatter-gather: sign-extend double word index.

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Abhinav Anil Sharma requested to merge i2985-sign-extend-index into master Dec 03, 2021
  • Overview 5
  • Commits 5
  • Pipelines 0
  • Changes 4

Fixes a crash in the expanded scatter gather sequence when a double word index is negative and needs to be sign-extended. Without sign extension, the computed address may be invalid (e.g. base + 0xffffffff, instead of base - 1). Double indices are always signed in scatter/gather instrs; they are already loaded in 32-bit registers in the expansion.

Also adds test for the same. Fixes some asm test code to use pcmpeqq for xmm comparisons; vcmpeqss does it only for the low 32-bits.

Issue: #2985 (closed)

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: i2985-sign-extend-index