Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • D dynamorio
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 1,467
    • Issues 1,467
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 44
    • Merge requests 44
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • DynamoRIO
  • dynamorio
  • Merge requests
  • !5184

i#5076 trace invariants, part 6: Count memrefs in view tool

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Derek Bruening requested to merge i5076-memrefs into master Nov 02, 2021
  • Overview 23
  • Commits 4
  • Pipelines 0
  • Changes 8

Changes the view tool's -skip_refs and -sim_refs behavior to count memrefs rather than instructions, for consistency with other tools. It was only counting instructions at all because until recently when it was augmented to print data and markers it only printed instructions.

Removes the feature of printing the version and filetype for -skip_refs as the usefulness is outweighed by messing up the reference count (not an issue with the instruction count).

Adds a new unit test for the view tool which mocks the module mapping and tests the skip_refs and num_refs options.

Issue: #5076 (closed)

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: i5076-memrefs