Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • D dynamorio
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 1,467
    • Issues 1,467
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 44
    • Merge requests 44
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • DynamoRIO
  • dynamorio
  • Merge requests
  • !5175

i#5177: Fix crash due to bad redirect in client.signal test

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Abhinav Anil Sharma requested to merge iX-fix-signal-test-crash into master Oct 25, 2021
  • Overview 12
  • Commits 6
  • Pipelines 0
  • Changes 5

Fixes a crash due to jumping in the middle of a routine in the client.signal test, which skips the saving/setting of the frame pointer added in the beginning of routines.

Redirects execution to the beginning of the hook routine, instead of somewhere in the middle which can cause issues if essential code sequences like this are skipped.

Documents a pitfall of using DR_SIGNAL_REDIRECT or dr_redirect_execution to redirect control to an arbitrary pc.

Fixes: #5177 (closed)

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: iX-fix-signal-test-crash