Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • D dynamorio
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 1,467
    • Issues 1,467
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 44
    • Merge requests 44
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • DynamoRIO
  • dynamorio
  • Merge requests
  • !5170

Fix drreg ever_spilled inaccuracy

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Derek Bruening requested to merge iX-drreg-xax-spilled into master Oct 20, 2021
  • Overview 11
  • Commits 3
  • Pipelines 0
  • Changes 2

Fixes a drreg bug in drreg_spill_aflags() which set xax's ever_spilled flag to true even if it wasn't spilled because it was dead. This caused requests to get the app value of xax to return success and to move aflags out of xax and into a slot, but without restoring the app value. The fixed behavior is to fail up front if xax is dead and so leave aflags in xax.

Updates the drreg tests that rely on getting the xax value moving aflags into a slot to use a live xax rather than a dead xax.

This was discovered while adding PR #5164 for #4128 (closed).

Issue: #4128 (closed)

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: iX-drreg-xax-spilled