Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • D dynamorio
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 1,467
    • Issues 1,467
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 44
    • Merge requests 44
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • DynamoRIO
  • dynamorio
  • Merge requests
  • !5119

i#5118: Restore drreg app values at annotation

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Derek Bruening requested to merge i5118-annot-call-app-vals into master Sep 23, 2021
  • Overview 12
  • Commits 5
  • Pipelines 0
  • Changes 7

Exports the DR_NOTE_ANNOTATION label identifier and has drreg look for it to treat an annotation label as a read of all register values.

Augments the annotation-detection full-decode tests to use drreg to clobber all annotation parameter registers. This causes test failure without the drreg fix added here.

Also tested on Dr. Memory's 32-bit mmap test (with a near-identical check in Dr. Memory's register spill code to what is here for drreg), which fails without this fix.

Fixes #5118 (closed)

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: i5118-annot-call-app-vals