Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • D dynamorio
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 1,467
    • Issues 1,467
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 44
    • Merge requests 44
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • DynamoRIO
  • dynamorio
  • Merge requests
  • !5106

i#5079: Avoid skipping get_pc_thunk after redirect.

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Abhinav Anil Sharma requested to merge i5079-pic-crash-x86-32 into master Sep 18, 2021
  • Overview 1
  • Commits 1
  • Pipelines 0
  • Changes 1

Moves accesses to global variables and string constants to a separate method that we always execute from the beginning.

Jumping to the middle of a routine using DR_SIGNAL_REDIRECT causes us to skip the __x86.get_pc_thunk.x calls that are required before accesses to global variables in PIC. This call allows accessing them using a fixed offset from code, by loading the pc of code in a register. Skipping this call may cause the program to crash due to a bad address.

This fixes the client.signal test on x86 32-bit, which would otherwise keep crashing in an infinite loop (the crash loop is due to other setup in this test).

Issue: #5079

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: i5079-pic-crash-x86-32