Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • D dynamorio
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 1,467
    • Issues 1,467
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 44
    • Merge requests 44
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • DynamoRIO
  • dynamorio
  • Merge requests
  • !5103

i#5101 pcache: Fix is-readable assert on pcache loading

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Derek Bruening requested to merge i5101-pcache-md5-exe into master Sep 17, 2021
  • Overview 2
  • Commits 3
  • Pipelines 0
  • Changes 2

Newer ld.so mprotects segments spanning a gap as no-access before it maps any contents. This can mean that these segments are no-access in all_memory_areas at the time we process a loaded executable segment, resulting in an assert when we try to compute the md5.

To solve this, we query the OS and not all_memory_areas (which is not updated until after the pcache is loaded). We also limit our md5 to only executable segments, rather than non-writable segments as before, to avoid trying to read the not-yet-mapped and no-access readonly-data segment (previously we were computing on the wrong content in any case before it was mapped).

Issue: #5101 (closed)

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: i5101-pcache-md5-exe