Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • D dynamorio
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 1,467
    • Issues 1,467
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 44
    • Merge requests 44
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • DynamoRIO
  • dynamorio
  • Merge requests
  • !5102

i#5079: Fix alignment of xsave area in kernel_fpstate_t.

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Abhinav Anil Sharma requested to merge i5079-signals-xstate-alignment into master Sep 16, 2021
  • Overview 8
  • Commits 10
  • Pipelines 0
  • Changes 2

Fixes alignment of xsave area in kernel_fpstate_t. The kernel requires it to be 64-byte aligned. Currently, we aligned the fpstate object itself, instead of the xsave area in it.

Without this, rt_sigreturn and sigreturn crash on x86 32-bit affecting all signal tests. With this fix, many signal tests work again, including linux.signalxxxx, linux.sigplainxxxx, linux.sigcontext, linux.signal_race. linux.alarm, linux.bad-signal-stack, linux.sigsuspend, linux.signest and a few others on Ubuntu 20.04.

Some others (linux.syscall_pwait, client.signal) now show a timeout, and client.events an assert failure. Those fixes will come later.

Issue: #5079, #4953 (closed)

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: i5079-signals-xstate-alignment