Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • D dynamorio
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 1,467
    • Issues 1,467
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 44
    • Merge requests 44
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • DynamoRIO
  • dynamorio
  • Merge requests
  • !5086

i#2626: AArch64 v8.0 decode: Fix misimplemented shifting instructions

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Administrator requested to merge i2626-correct-shift-operands into master Sep 10, 2021
  • Overview 1
  • Commits 1
  • Pipelines 0
  • Changes 2

Created by: joshua-warburton

Many of the AArch64 entries using the <#shift> argument were incorrectly decoding the value of the shift. This incorrect decoding was recorded in the tests and thus was not caught.

This patch has replaced all the incorrect implementations with correct ones and increases the test coverage

Issue: #2626

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: i2626-correct-shift-operands