Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • D dynamorio
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 1,467
    • Issues 1,467
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 44
    • Merge requests 44
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • DynamoRIO
  • dynamorio
  • Merge requests
  • !5068

i#5067: Do not skip version in view tool

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Derek Bruening requested to merge i5067-view-skip-ver into master Sep 01, 2021
  • Overview 8
  • Commits 2
  • Pipelines 0
  • Changes 2

When -skip_refs is passed, the view tool still needs to look at the initial metadata to obtain the trace version and file type.

Tested: Before: $ bin64/drrun -t drcachesim -offline -- suite/tests/bin/linux.signest $ bin64/drrun -t drcachesim -simulator_type view -skip_refs 100 -indir drmemtrace.linux.signest..dir/ 2>&1 | egrep 'version|kernel xfer' T1602962 <marker: version -1> T1602964 <marker: version -1> T1602964 <marker: kernel xfer from module offset +0x7fc58e2bd212 to handler> T1602964 <marker: kernel xfer from module offset +0x7fc58e2bd212 to handler> T1602964 <marker: kernel xfer from module offset +0x7fc58e2bd212 to handler> T1602964 <marker: kernel xfer from module offset +0x7fc58e2b87b2 to handler> After: $ bin64/drrun -t drcachesim -simulator_type view -skip_refs 100 -indir drmemtrace.linux.signest..dir/ 2>&1 | egrep 'version|kernel xfer' T1602962 <marker: version 3> T1602964 <marker: version 3> T1602964 <marker: kernel xfer from 0x7fc58e2bd212 to handler> T1602964 <marker: kernel xfer from 0x7fc58e2bd212 to handler> T1602964 <marker: kernel xfer from 0x7fc58e2bd212 to handler> T1602964 <marker: kernel xfer from 0x7fc58e2b87b2 to handler>

Fixes #5067 (closed)

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: i5067-view-skip-ver