Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • D dynamorio
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 1,467
    • Issues 1,467
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 44
    • Merge requests 44
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • DynamoRIO
  • dynamorio
  • Merge requests
  • !5003

i4489 drcachesim: support any associativity

  • Review changes

  • Download
  • Email patches
  • Plain diff
Open Al Grant requested to merge github/fork/algrant-arm/i4489-drcachesim-assoc2 into master Jul 09, 2021
  • Overview 6
  • Commits 1
  • Pipelines 0
  • Changes 9

drcachesim used to support only power-of-2 associativity even though it's not uncommon for L1 caches to be 3-way, 5-way, or sometimes 24-way for larger caches. Most changes were in option validation and related messages. The use of assoc_bits_ was removed. Shifts and masks were replaced by multiplication (as cheap as shifting, on modern CPUs) and a test. There are no division or modulo operators on the speed path.

This also seemed like a good opportunity to change the misnamed blocks_per_set_ variable to blocks_per_way_ (blocks per set is the same as associativity).

Reworked pull request to fix clang-format issues.

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: github/fork/algrant-arm/i4489-drcachesim-assoc2