Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • D dynamorio
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 1,467
    • Issues 1,467
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 44
    • Merge requests 44
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • DynamoRIO
  • dynamorio
  • Merge requests
  • !4997

i#4984 view tool: Fix stale prefix on 2-line-disasm bug

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Derek Bruening requested to merge i4984-nocache-tid into master Jul 08, 2021
  • Overview 2
  • Commits 1
  • Pipelines 0
  • Changes 1

Moves the TID prefix outside of the cached disassembly to avoid a stale prefix in drcachesim's view tool.

Tested manually:

  --------------------------------------------------
  $ bin64/drrun -t drcachesim -offline -- suite/tests/bin/drmemtrace.signal_invariants
  $ bin64/drrun -t drcachesim -indir drmemtrace.drm*[0-9]*.dir -simulator_type view 2>&1 | less
  --------------------------------------------------

Before:

  --------------------------------------------------
  T480221   0x00007ff86d0c4648  48 89 94 24 50 02 00 mov    %rdx, 0x00000250(%rsp)
  T480218                       00
  T480221     write 8 byte(s) @ 0x7ff86c96fd50
  T480221   0x00007ff86d0c4650  48 89 94 24 58 02 00 mov    %rdx, 0x00000258(%rsp)
  T480218                       00
  T480221     write 8 byte(s) @ 0x7ff86c96fd58
  T480221   0x00007ff86d0c4658  48 89 94 24 60 02 00 mov    %rdx, 0x00000260(%rsp)
  T480218                       00
  T480221     write 8 byte(s) @ 0x7ff86c96fd60
  T480221   0x00007ff86d0c4660  48 89 94 24 68 02 00 mov    %rdx, 0x00000268(%rsp)
  T480218                       00
  T480221     write 8 byte(s) @ 0x7ff86c96fd68
  --------------------------------------------------

After:

  --------------------------------------------------
  T480221   0x00007ff86d0c4648  48 89 94 24 50 02 00 mov    %rdx, 0x00000250(%rsp)
  T480221                       00
  T480221     write 8 byte(s) @ 0x7ff86c96fd50
  T480221   0x00007ff86d0c4650  48 89 94 24 58 02 00 mov    %rdx, 0x00000258(%rsp)
  T480221                       00
  T480221     write 8 byte(s) @ 0x7ff86c96fd58
  T480221   0x00007ff86d0c4658  48 89 94 24 60 02 00 mov    %rdx, 0x00000260(%rsp)
  T480221                       00
  T480221     write 8 byte(s) @ 0x7ff86c96fd60
  T480221   0x00007ff86d0c4660  48 89 94 24 68 02 00 mov    %rdx, 0x00000268(%rsp)
  T480221                       00
  T480221     write 8 byte(s) @ 0x7ff86c96fd68
  --------------------------------------------------

Issue: #4984 (closed)

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: i4984-nocache-tid