Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • D dynamorio
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 1,467
    • Issues 1,467
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 44
    • Merge requests 44
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • DynamoRIO
  • dynamorio
  • Merge requests
  • !4945

i#4865 emul: Refactor drmgr callback list management

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Derek Bruening requested to merge i4865-drmgr-refactor into master Jun 10, 2021
  • Overview 1
  • Commits 2
  • Pipelines 0
  • Changes 1

The drmgr_bb_cb_add() and drmgr_bb_cb_remove() functions had become unwieldy over time, with very long lists of parameters and complex conditionals. This makes it difficult to add new callbacks. Here we refactor them to take in helpers to set key fields while sharing all of the other code.

A new has_pair field is also added. This fixes a bug where drmgr_register_opcode_instrumentation_event() incorrectly increased the pair count.

Issue: #4865 (closed)

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: i4865-drmgr-refactor