Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • D dynamorio
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 1,467
    • Issues 1,467
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 44
    • Merge requests 44
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • DynamoRIO
  • dynamorio
  • Merge requests
  • !4909

i#2985 scatter-gather: Fix scratch mask restoration on fault during scatter

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Abhinav Anil Sharma requested to merge i2985-memval-with-scattergather into master May 12, 2021
  • Overview 23
  • Commits 8
  • Pipelines 0
  • Changes 5

Adds a missing state transition that was causing restoration of the wrong value to scratch mask k0. This was resulting in a ERROR: expected k0 == 0xffff, but is 0xd360 error in the drx-scattergather app.

Postpones updating trace buffer ptr in the memval_simple sample client to post-write. This is to mitigate cases when the write buffer doesn't get written to due to the app write segfaulting, which results in no matching entry in the write buffer for the trace buffer entry. This causes an assert failure later write_base <= write_ptr in trace_fault.

Adds a test that runs the drx-scattergather app under the memval_simple client to verify the above two fixes.

Issue: #2985 (closed)

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: i2985-memval-with-scattergather