Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • D dynamorio
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 1,467
    • Issues 1,467
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 44
    • Merge requests 44
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • DynamoRIO
  • dynamorio
  • Merge requests
  • !4886

i#4884: Check signal exit before syscall, etc. reasons

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Derek Bruening requested to merge i4878-signal-pend-vs-ib-exit into master Apr 28, 2021
  • Overview 4
  • Commits 3
  • Pipelines 0
  • Changes 1

Adds a pending-signal check to avoid attempting to run a syscall for a signal arriving in the cache, avoiding running pre-syscall handling only to abort and have complications with undoing or duplicating actions.

For a signal arriving in DR while executing a syscall, changes DR to go ahead and do the syscall for all non-ignorable syscalls, again avoiding complications with undoing or duplicating pre-syscall action. Previously, this was only done for sigreturn or clone syscalls. Non-ignorable syscalls generally do not block, so this should not impact signal delivery delays.

Moves the pending-signal check to be the first thing checked for the exit reason, for proper exit attribution.

Avoids the IBT add code for a pending-signal exit.

Tested on the large proprietary app where the wrong exit reasons were first observed. Adding a regression suite test for these asynchronous signal conditions is not easy unfortunately.

Issue: #4878 (closed), #4884 (closed) Fixes: #4884 (closed)

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: i4878-signal-pend-vs-ib-exit