Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • D dynamorio
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 1,467
    • Issues 1,467
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 44
    • Merge requests 44
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • DynamoRIO
  • dynamorio
  • Merge requests
  • !4864

i#4857: Add instr count to drmemtrace filtered traces

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Derek Bruening requested to merge i4857-filter-count into master Apr 21, 2021
  • Overview 1
  • Commits 3
  • Pipelines 0
  • Changes 15

Adds tracking of the dynamic (pre-filtered) instruction count for each thread. Stores the count in a marker at thread exit (storing prior to each miss entry might be useful but in experiments it adds too much overhead to include without a clear mandate and possibly under an off-by-default runtime option).

Adds a check to the filter tests confirming that the instruction count marker is present at thread exit for filtered traces. This is done by invoked test_mode for these traces. To simplify testing for online and offline, the trace type marker is added to online traces.

Adds a new tool.drcachesim.filter-asm test which ensures the instr count is the precise count expected for that fully-deterministic tiny static binary.

A larger-than-static-asm application was manually tested, confirming the need for the rep string expansion special case in the code to limit to 1 instruction for that block.

Fixes #4857 (closed)

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: i4857-filter-count