Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • D dynamorio
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 1,467
    • Issues 1,467
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 44
    • Merge requests 44
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • DynamoRIO
  • dynamorio
  • Merge requests
  • !4778

i#4777: Fix uninitialized drmodtrack offset on Windows

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Derek Bruening requested to merge i4777-uinit-drmodtrack-offset into master Mar 10, 2021
  • Overview 4
  • Commits 2
  • Pipelines 0
  • Changes 2

PR #2940 and #2973 added an offset field to drmodtrack for #2939 (closed), but they ifdef-ed the field in some places but not others, resulting in uninitialized output. Since it's already locked into the interface, we always set it to 0 here and include it in internal structures to fix the problem.

Tested on drmodtrack-test where the fields were manually confirmed to no longer contain bogus values, and where the test doesn't fail when i#4474 adds a new field that shifts the test buffer to avoid the happens-to-match scenario that masked this bug in that test before.

Issue: #2939 (closed), #4474, #4777 (closed) Fixes #4777 (closed)

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: i4777-uinit-drmodtrack-offset