Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • D dynamorio
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 1,467
    • Issues 1,467
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 44
    • Merge requests 44
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • DynamoRIO
  • dynamorio
  • Merge requests
  • !4691

i#4680 aarch xl8: Fix GPR restore bug on cross-app spills

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Derek Bruening requested to merge i4680-cross-app-spills into master Jan 25, 2021
  • Overview 1
  • Commits 1
  • Pipelines 0
  • Changes 1

Fixes a translation bug in translate_walk_restore() where it just skips GPR restores if it's in between application instructions. Since on AArchXX we have many of these cases of cross-app-instr spills (due to restore elision for back-to-back spills), the assumption that there will be no outstanding spills does not hold.

The solution is to move the condition to only encompass the stack pointer restore, while the GPR restores should always be done.

This was caught by the forthcoming common.broadfun-stress test, which will serve as the regression test once it is added after all other bugs it finds are addressed.

Issue: #4680 (closed)

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: i4680-cross-app-spills