Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • D dynamorio
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 1,467
    • Issues 1,467
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 44
    • Merge requests 44
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • DynamoRIO
  • dynamorio
  • Merge requests
  • !4672

i#4669 xl8 failures: No asserts for client xl8 requests

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Derek Bruening requested to merge i4669-client-request-xl8 into master Jan 13, 2021
  • Overview 6
  • Commits 1
  • Pipelines 0
  • Changes 4

Applies the existing client_data->is_translating debug flag to avoid a curiosity and an assert on translation failure stemming from client use of dr_app_pc_from_cache_pc() on a sampling itimer.

Augments the client.timer test to run with -disable_traces and use a lot of indirect branches to trigger a curiosity on xl8 failure on every run when the iterations are increased (a little too high for our small regression tests though). With this fix, the curiosity never occurs.

Issue: #4669

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: i4669-client-request-xl8