Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • D dynamorio
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 1,467
    • Issues 1,467
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 44
    • Merge requests 44
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • DynamoRIO
  • dynamorio
  • Merge requests
  • !4613

i#4609 encode instr addr imm: Fix insert_mov_immed_arch

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Abhinav Anil Sharma requested to merge i4609-encode-instr-addr-immm into master Dec 15, 2020
  • Overview 30
  • Commits 10
  • Pipelines 0
  • Changes 6

Fixes implementation of insert_mov_immed_arch to mov encoded value of given instruction, instead of wrongly using the encode estimate. This also fixes instrlist_insert_mov_instr_addr.

Handles INSTR_kind imm16 operands in codec, which are used in mov instrs to store in a reg the encoded addr of an instr.

Adds codec test to verify that the correct bits are stored by the codec, as given by the shift amount and opnd size args. Also adds a drdecode test to verify instrlist_insert_mov_instr_addr.

Fixes: #4609 (closed)

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: i4609-encode-instr-addr-immm