Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • D dynamorio
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 1,467
    • Issues 1,467
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 44
    • Merge requests 44
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • DynamoRIO
  • dynamorio
  • Merge requests
  • !4526

i#4495: Preserve translated stolen register

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Derek Bruening requested to merge i4495-stolen-reg-client-change into master Nov 11, 2020
  • Overview 9
  • Commits 2
  • Pipelines 0
  • Changes 9

Currently, a stolen register value that is translated by a client is discarded both in a synchall and a synchronous signal. We fix both paths here.

Adds a new test client.stolen-reg which tests both a synchronous fault signal translation path as well as a synchall translation path via a synchall flush. The test was confirmed to fail without either of the fixes in place.

Ensures the new test passes on 32-bit ARM. This exercised the translate_from_synchall_to_dispatch() path and found some ARM bugs: the reset exit stub is A32 mode, so we need to change the mode for the suspended sigcontext; yet thread_set_mcontext() did not support that. That is all fixed now and verified.

Fixes #4495 (closed)

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: i4495-stolen-reg-client-change