Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • D dynamorio
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 1,467
    • Issues 1,467
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 44
    • Merge requests 44
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • DynamoRIO
  • dynamorio
  • Merge requests
  • !4517

i#4460: Restore stolen reg on signal in auto-restart syscall

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Derek Bruening requested to merge i4460-stolen-reg-auto-restart into master Nov 04, 2020
  • Overview 1
  • Commits 1
  • Pipelines 0
  • Changes 4

Adds a missing restore of the app's stolen register value into the signal frame's ucontext when a signal interrupts an auto-restart syscall. In that case, we do not go through the full translation path and instead perform a custom translation, which is why we missed this step.

Adds asserts on several signal paths to help detect similar errors or regressions in the future.

Adds comments making it more clear what is in the stolen register's mcontext slot while in the cache.

Tested on the linux.eintr test which fails with the new asserts but without the fix. Additionally tested on the proprietary app where it was first encountered.

Fixes #4460 (closed)

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: i4460-stolen-reg-auto-restart