Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • D dynamorio
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 1,467
    • Issues 1,467
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 44
    • Merge requests 44
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • DynamoRIO
  • dynamorio
  • Merge requests
  • !4513

i#4508: Stolen register not loaded in dr_get_mcontext on AArch64

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged gregcawthorne requested to merge i4508-aarch64-stolen-register-to-mcontext into master Nov 02, 2020
  • Overview 77
  • Commits 49
  • Pipelines 0
  • Changes 4

i#4508 Dynamorio not loading stolen register value into mcontext on AArch64.

On AArch64 the value of the stolen register isn't loaded into the mcontext object for later instrumentation.

This is due to an ifdef only allowing this functionality on ARM (non AArch64), in core/lib/instrument.c, dr_get_mcontext_priv().

This causes errors when addresses need to be calculated based on the value of contents the stolen register.

Fix is a simple update of an #ifdef from #ifdef ARM to ifdef AARCHXX

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: i4508-aarch64-stolen-register-to-mcontext