Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • D dynamorio
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 1,467
    • Issues 1,467
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 44
    • Merge requests 44
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • DynamoRIO
  • dynamorio
  • Merge requests
  • !4494

i#4159 marker overflow: Use filter flag for 1-instr blocks

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Derek Bruening requested to merge i4159-filter-1-instr into master Oct 22, 2020
  • Overview 1
  • Commits 1
  • Pipelines 0
  • Changes 1

Extends PR #4236 to cover 1-instruction blocks in filtered traces, and not just 0-instruction blocks, using the top-level filter type flag. This avoids filling the buffer up with markers using the escape back to the main loop from PR #4236.

Tested on a proprietary app where drcachesim with filtering hits the assert added in PR #4236. This change fixes it.

For a local test: it may be tricky to arrange a live trace to have enough markers in a row; maybe a synthetic trace. For now just going with the manual proprietary test run.

Issue: #4159

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: i4159-filter-1-instr